Skip to content

Allow setting volume type for node group extra_volumes parameter #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

Allow setting volume type for node group extra_volumes parameter #755

merged 2 commits into from
Aug 12, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Aug 7, 2025

No description provided.

@sjpb sjpb marked this pull request as ready for review August 12, 2025 10:06
@sjpb sjpb requested a review from a team as a code owner August 12, 2025 10:06
@sjpb sjpb requested a review from wtripp180901 August 12, 2025 10:06
wtripp180901
wtripp180901 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit f9dbeb2 into main Aug 12, 2025
1 of 4 checks passed
@sjpb sjpb deleted the feat/compute-volume-type branch August 12, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @wtripp180901